Make normalization prelude tests import only the package they need #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't run all the tests because my implemntation doesn't support everything, but the 51 I could run went fine, so I haven't broken everything. |
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Mar 12, 2019
As standardized in dhall-lang/dhall-lang#420
Gabriella439
approved these changes
Mar 12, 2019
There was a problem hiding this comment.
I verified that the tests still pass for the Haskell implementation. Here is the matching pull request: dhall-lang/dhall-haskell#850
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Mar 12, 2019
As standardized in dhall-lang/dhall-lang#420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now running those tests takes an eternity because I need to reparse and normalize the whole prelude every time. I've made the tests import only the file they need, like they do in the prelude typechecking tests.