Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imports have whitespace before the hash #452

Merged
merged 2 commits into from Apr 6, 2019
Merged

imports have whitespace before the hash #452

merged 2 commits into from Apr 6, 2019

Conversation

singpolyma
Copy link
Collaborator

@singpolyma singpolyma commented Apr 4, 2019 •
edited

This seems to be an omission from #442

@singpolyma
imports have whitespace before the hash
0e0a09e 
This seems to be an omission from
dhall-lang#442
Nadrieril
Nadrieril approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@Nadrieril Nadrieril left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this !
Weirdly enough, it seems that before #442, the grammar allowed empty whitespace before the hash. I agree with you that nonempty whitespace is more reasonable however.

f-f
f-f approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

This was referenced Apr 4, 2019
Merged
Closed
@singpolyma singpolyma merged commit 35243fa into dhall-lang:master Apr 6, 2019
@singpolyma singpolyma deleted the fix-import-hash-whitespace branch April 6, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

@f-f f-f f-f approved these changes

@Nadrieril Nadrieril Nadrieril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@singpolyma @Gabriella439 @f-f @Nadrieril