Left-factor grammar for domains #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These rules should be equivalent but more amenable to recursive descent parsers and bulk parsing operators
|
I believe this is not quite equivalent -- domain must not end with "-"
|
|
@singpolyma: I believe that is still the case because a set of dashes has to be followed by one or more |
|
If I'm not mistaken, this is not equivalent for PEG parsers, but you're actually fixing a bug: previously, a PEG parser would have failed to parse a domain with a trailing period (like |
|
@singpolyma: I believe that is still the case because a set of dashes has to be followed by one or more `ALPHANUM` characters
Oh, that's right. Bad reading on my part :)
|
f-f
approved these changes
Jul 18, 2019
singpolyma
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules should be equivalent but more amenable to
recursive descent parsers and bulk parsing operators