Extend valid set of quoted labels to period #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to dhall-lang#76 This adds `.` to the list of supported characters for Dhall labels.
|
Looks good to me! I'll wait 3 days and if nobody objects to this change then I'll merge this and update the Haskell implementation to match |
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Jan 27, 2018
... as standardized in dhall-lang/dhall-lang#77
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Jan 27, 2018
... as standardized in dhall-lang/dhall-lang#77
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Jan 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #76
This adds
.to the list of supported characters for Dhall labels.