New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a README
for the Prelude
#793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This `README` discusses how to use and contribute to the Prelude
f-f
approved these changes
Oct 26, 2019
sjakobi
approved these changes
Oct 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments needn't be addressed in this PR.
* Fix `https://prelude.dhall-lang.org` to point to latest release instead of `master` * Support `https://prelude.dhall-lang.org/vX.Y.Z` ... as suggested by @sjakobi
... as suggested by @sjakobi Co-Authored-By: Simon Jakobi <simon.jakobi@gmail.com>
…lang into gabriel/Prelude_README
sjakobi
reviewed
Oct 26, 2019
@@ -187,9 +189,10 @@ | |||
add_header 'Access-Control-Expose-Headers' 'Content-Length,Content-Range'; | |||
} | |||
|
|||
rewrite ^/?$ https://github.com/dhall-lang/dhall-lang/tree/master/Prelude redirect; | |||
rewrite ^/?$ https://github.com/dhall-lang/dhall-lang/tree/${latestRelease}/Prelude redirect; | |||
rewrite ^/(v[^/]+)$ https://github.com/dhall-lang/dhall-lang/tree/$1/Prelude redirect; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! :)
singpolyma
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
README
discusses how to use and contribute to the Prelude