Increase precedence of parsing variable names #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this change is to permit identifiers that begin with reserved keywords. Here are some example issues due to Dhall previously not supporting that: * dhall-lang/dhall-haskell#250 * #59 After this change, names like `List/map` or `TypeSynonym` would become legal. However, this should not break any existing code because variable names will still reject reserved identifiers.
This was referenced Feb 3, 2018
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Feb 7, 2018
... as standardized in dhall-lang/dhall-lang#83 Fixes #250 This allows identifier names to begin with reserved identifiers. For example, previously `TypeSynonym` was not a valid identifier because it began with `Type` and now it is a valid identifier.
Gabriella439
added a commit
to dhall-lang/dhall-haskell
that referenced
this pull request
Feb 8, 2018
... as standardized in dhall-lang/dhall-lang#83 Fixes #250 This allows identifier names to begin with reserved identifiers. For example, previously `TypeSynonym` was not a valid identifier because it began with `Type` and now it is a valid identifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to permit identifiers that begin with
reserved keywords. Here are some example issues due to Dhall
previously not supporting that:
After this change, names like
List/maporTypeSynonymwould become legal. However, this should not break any
existing code because variable names will still reject reserved
identifiers.