Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON/renderYAML for singleton arrays/objects #929

Merged
merged 3 commits into from Mar 9, 2020

Conversation

Gabriella439
Copy link
Contributor

Fixes #927

Copy link
Collaborator

@sjakobi sjakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Much better than what I had come up with!

: ∀(a : Type) → NonEmpty a → List a
= λ(a : Type) → λ(nonEmpty : NonEmpty a) → [ nonEmpty.head ] # nonEmpty.tail

let concatNonEmpty
let NonEmpty/concat
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel embarrassed I didn't come up with this kind of naming myself 🤦‍♂️ :)

Copy link
Collaborator

@timbertson timbertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Gabriella439 Gabriella439 merged commit 527f391 into master Mar 9, 2020
@Gabriella439 Gabriella439 deleted the gabriel/fix_renderYAML branch March 9, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON.renderYAML output is invalid for a property with a single-element list
4 participants