Upgrade android media library #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also requires updating our target SDK version to 34. Hopefully this will resolve some of the crashes we've been seeing in production, particularly on Samsung devices.
intermarc
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
That is a very promising update @bb4242. It really does sound like the new media library will address the issues you have noticed. I don't have any experience with the build system and dependency handling for android apps, so all I can really say is that none of the changes look obviously broken to me!
I've been testing media-1.2.0 on my phone for a few days and have not had any issues at all (neither building and installing nor in use). So it's all green lights from me 👍
bb4242
added a commit
that referenced
this pull request
Dec 19, 2023
For background on the issue, and why this change may help, see androidx/media#890. I had hoped that upgrading the Media3 library version back in #92 would completely solve the problems we had been seeing in production. While it did help in some ways, by eliminating `ForegroundServiceDidNotStartInTimeException`s (see androidx/media#167), it also seems to have morphed a lot of problems into a new form, namely App Not Responding (ANR) problems that arise in `MiniPlayerFragment`. The basic idea here is to reduce the rate at which we create and release `MediaController`s in `MiniPlayerFragment`, by moving the creation and releasing to fragment lifecycle callbacks that are invoked less frequently than `onResume()` and `onPause()`. My hypothesis is that rapid creation and releasing of `MediaController`s results in some kind of race condition that is very hard to reproduce locally but will occur in production with enough use of the app. It's not completely clear that this PR will definitely solve the problems we're seeing in production, but it seems like a worthwhile experiment to try. Other than potentially decreasing the rate of ANRs, it should not have any other noticeable effects on the behavior of the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version, 1.2.0, of the android media library was just released. This release includes several fixes that are relevant to androidx/media#167, which seems to be the root cause of some issues we've been seeing in production, particularly on Samsung devices. Among many other changes, the release notes for 1.2.0 say this: "Use only android.media.session.MediaSession.setMediaButtonBroadcastReceiver() above API 31 to avoid problems with deprecated API on Samsung devices (androidx/media#167)." I'm hopeful that upgrading to 1.2.0 will resolve our issues in production. We'll be able to monitor the impact of the upgrade using crashlytics (see #91).
Upgrading to 1.2.0 also required upgrading our
targetSdkto version 34. This was straightforward, it just required adding one more permission that is now required by Android for playing media in a foreground service. I also updated thecom.google.android.materiallibrary for good measure as it was slightly out of date; this shouldn't have any noticeable impact.