Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dual-licensing detection #64

Closed
joshfriend opened this issue Apr 2, 2021 · 0 comments · Fixed by #66
Closed

Improve dual-licensing detection #64

joshfriend opened this issue Apr 2, 2021 · 0 comments · Fixed by #66

Comments

@joshfriend
Copy link
Contributor

Ran into an issue with python-dateutil where the license="Dual License" in setup.cfg, but the trove classifiers report Apache 2.0 and BSD 3-clause. My license check failed because "Dual" was not an approved license.

My suggestion here would be to ignore the plain License: * metadata if Classifier: License :: * metadata exists, instead of combining them into a list:

# Current:
licenses = get_license(dist) + get_license_OSI_classifiers(dist)
# Suggestion
licenses = get_license_OSI_classifiers(dist) or get_license(dist) or ['Unknown']

simplejson is another dual-license example, though their metadata specifies it a bit differently:

License: MIT License
License :: OSI Approved :: MIT License
License :: OSI Approved :: Academic Free License (AFL)
joshfriend pushed a commit to MichiganLabs/python-license-check that referenced this issue Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant