Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentication #11

Open
rofl0r opened this issue Nov 26, 2015 · 10 comments
Open

authentication #11

rofl0r opened this issue Nov 26, 2015 · 10 comments

Comments

@rofl0r
Copy link

rofl0r commented Nov 26, 2015

there should be some means of encrypted (one-time) authentication (per ip) so not everyone can use the icmp proxy server.

@stoofz
Copy link

stoofz commented Jan 7, 2016

agreed

@Gandalf-
Copy link

On server startup the user could specify a pre-shared key or password and we have the client send the password as the first message to the server. Everything is plain text, so it could be sniffed, but not anyone could use the server anymore just by knowing the server IP + port.

@DhavalKapil
Copy link
Owner

+1 for pre-shared key/password. I'm also planning to add encryption, that is, when I get some time for this.

@Gandalf-
Copy link

In that case it probably makes more sense to use TLS with a client certificate. That'll provide encryption and authentication that can't be sniffed since it uses a DH handshake.

Have there been any problems with reliability? The handshake could be difficult to complete over ICMP since it's unreliable like UDP.

Also, is a session defined by a client IP?

@rofl0r
Copy link
Author

rofl0r commented Mar 26, 2016

rather than going for an overkill solution like TLS (which will be hard to implement with icmp packet size!) i'd rather go for something based on djb's tweetnacl crypto primitives, which fit in a single, small .c file.
( https://tweetnacl.cr.yp.to/ )

@DhavalKapil
Copy link
Owner

@Gandalf- If the client and server are accessible within the same LAN network, the connection can be assumed to be reliable. Cannot say much for connections over the internet. And yes TLS with client certificate might be too much for icmptunnel.

@Gandalf-
Copy link

I hadn't heard about tweetnacl; it does look like a good option. Is there already a fork or branch working on this?

@greg5678
Copy link

greg5678 commented Jun 30, 2016

So @DhavalKapil have you have a change to add some form of authentication?

@DhavalKapil
Copy link
Owner

@greg5678 Not yet

@wangyu-
Copy link

wangyu- commented Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants