Websocket server URL with no path in the end are not parsed! #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhbaird
added a commit
that referenced
this pull request
Apr 27, 2013
Websocket server URL with no path in the end are not parsed! (but now they are)
|
This looks great @helloIAmPau, you're awesome. I'm going to merge this. If you have a minute, can you also add a case to handle when :port is missing as well? (This would fit nicely along with this patch). |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the possibility to use websocket server URLs with no path in the end.
I hope that you appreciate it.
Goodbye! :)