feat: add ledger integration #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evias
reviewed
Sep 13, 2023
| @@ -32,7 +32,7 @@ export class AccountService { | |||
| * Default account derivation path | |||
| * @var {string} | |||
| */ | |||
| private static readonly DEFAULT_ACCOUNT_PATH_MAIN_NET = `m/44'/4343'/0'/0'/0'`; | |||
| private static readonly DEFAULT_ACCOUNT_PATH_MAIN_NET = `m/44'/10111'/0'/0'/0'`; | |||
There was a problem hiding this comment.
that is not a good idea, considering that it will break everyone's wallet access
There was a problem hiding this comment.
It only takes the BIP32 path when creating the profile, saved profiles will be accessible normally (as private keys are stored locally).
There was a problem hiding this comment.
There's one case that if user chose to import their profile from mnemonics, they will see different addresses, but we can notify them to send tokens to the new addresses, or they can use the previous version of the wallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.