Remove body from HttpLike #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need for the body prop as signatures are not concerned with the body of the request. All data required for signing/verifying http-signatures are based in the request line and headers.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need for the body prop as signatures are not concerned with the body of the request.
All data required for signing/verifying http-signatures are based in the request line and headers.
As discussed in other issues, the library should have a clearly defined remit, and that is simply to generate the signature header and to validate signature headers.
Other steps that may be related to signatures but not actually part of the signing process should be handled separately (eg: calculating body digests).