chore(lint): fix unicorn/no-negated-condition

dherault · Jan 2, 2023 · d151b0a · d151b0a
1 parent 016bd42
commit d151b0a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -76,7 +76,6 @@ module.exports = {
     'unicorn/no-array-reduce': 'off',
     'unicorn/no-await-expression-member': 'off',
     'unicorn/no-lonely-if': 'off',
-    'unicorn/no-negated-condition': 'off',
     'unicorn/no-new-array': 'off',
     'unicorn/no-null': 'off',
     'unicorn/no-static-only-class': 'off',

diff --git a/src/events/http/HttpServer.js b/src/events/http/HttpServer.js
@@ -328,9 +328,9 @@ export default class HttpServer {
         'method.request.header.Authorization',
       identityValidationExpression:
         serverlessAuthorizerOptions?.identityValidationExpression || '(.*)',
-      payloadVersion: !endpoint.isHttpApi
-        ? '1.0'
-        : serverlessAuthorizerOptions?.payloadVersion || '2.0',
+      payloadVersion: endpoint.isHttpApi
+        ? serverlessAuthorizerOptions?.payloadVersion || '2.0'
+        : '1.0',
       resultTtlInSeconds:
         serverlessAuthorizerOptions?.resultTtlInSeconds || '300',
     }
@@ -502,9 +502,9 @@ export default class HttpServer {
           : ''
 
       const schemas =
-        endpoint?.request?.schemas !== undefined
-          ? endpoint.request.schemas[contentType]
-          : ''
+        endpoint?.request?.schemas === undefined
+          ? ''
+          : endpoint.request.schemas[contentType]
 
       // https://hapijs.com/api#route-configuration doesn't seem to support selectively parsing
       // so we have to do it ourselves

diff --git a/src/lambda/handler-runner/docker-runner/DockerContainer.js b/src/lambda/handler-runner/docker-runner/DockerContainer.js
@@ -95,13 +95,7 @@ export default class DockerContainer {
     if (this.#layers.length > 0) {
       log.verbose(`Found layers, checking provider type`)
 
-      if (this.#provider.name.toLowerCase() !== 'aws') {
-        log.warning(
-          `Provider ${
-            this.#provider.name
-          } is Unsupported. Layers are only supported on aws.`,
-        )
-      } else {
+      if (this.#provider.name.toLowerCase() === 'aws') {
         let layerDir = this.#dockerOptions.layersDir
 
         if (!layerDir) {
@@ -142,6 +136,12 @@ export default class DockerContainer {
           )
         }
         dockerArgs.push('-v', `${layerDir}:/opt:ro,delegated`)
+      } else {
+        log.warning(
+          `Provider ${
+            this.#provider.name
+          } is Unsupported. Layers are only supported on aws.`,
+        )
       }
     }