Problem with parsing JSON requestTemplate since it is already js object

[rallu]

I had problem with parsing my request templates. I made this little fix to test if template is already js object:

In index.js:163

var jsonContent = requestTemplates[contentType];
let toApply = jsonContent;
if (typeof jsonContent != 'object') {
  toApply = JSON.parse(jsonContent);
}

[dherault]

You're right, requestTemplates as defined per const requestTemplates = endpoint.requestTemplates; is already an Object, so there is no need for parsing. I've been working on 1.0 (that should supports velocity in full) on master but I'll create a branch for it.

Allow 30 min, I'll publish a new version applying your fix. Make sure you've read the source (you've done it obviously) before using the --useTemplates option, it's very opinionated.

Thanks for the issue!

[rallu]

Yeah. I noticed that after fiddling for a while. Then I found another error in second route and ended up catching whole error:

try {
  toApply = JSON.parse(jsonContent);
} catch (e) {
  toApply = {};
}

This way it at least doesn't crash all the time.

[dherault]

I wanted to get rid of the JSON parsing, but do you think it is still necessary ?

[rallu]

Just get rid of it. It was nice to have something automatic for simple cases.

[dherault]

This is a fix, not amazing:

// Then we create the event object
const event = Object.assign({ isServerlessOffline: true }, request);

if (requestTemplates && this.evt.useTemplates) {
  // Apply request template to event
  const requestTemplate = requestTemplate[request.mime || 'application/json'];
  if (typeof requestTemplate === 'object') {
    try {
      // TODO: proces $context variables in a more complete way http://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-mapping-template-reference.html#context-variable-reference
      // TODO: $input could also be dealt with in a more robust way http://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-mapping-template-reference.html#input-variable-reference
      for (let key in requestTemplate) {

        if (requestTemplate[key] === '$context.httpMethod') {
          event[key] = request.method.toUpperCase();
        } else if (requestTemplate[key] === '$input.params()') {
          event[key] = request.params;
        } else {
          const reResp = reInputParam.exec(requestTemplate[key]);
          if (reResp) {
            // lookup variable replacement in params
            const paramName = reResp[1];
            event[key] = paramName in event.params ? event.params[paramName] : '';
          }
          else {
            event[key] = requestTemplate[key];
          }
        }
      }
    }
    catch (err) {
      SCli.log('Error while trying to use your templates:');
      console.log(err.stack || err);
      serverResponse.statusCode = 500;
      serverResponse.source = 'Error while trying to use your templates.';
      serverResponse.send();
      return;
    }
  }
}

What do you think ?

[dherault]

I replaced if (typeof requestTemplate === 'object') { with if (requestTemplate) {

[dherault]

Publised under v0.2.2