Expose Option: ignorePackageArtifact #1208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is helpful for projects not yet ready or able to run the project using the artifact. Defaults to false. If `ignorePackageArtifact: true` is added to the serverless.yml custom.serverless-offline configuration section, the source files will be used to run the offline lambda.
nponeccop
reviewed
Apr 7, 2021
Leglaw
force-pushed
the
do/ignore-package-artifact-option
branch
from
fa5ab30
to
6fcc5e5
Compare
|
Hello @Leglaw - it looks good overall, however, it misses the suggestion from @nponeccop about |
|
I too am waiting on this feature. I created a relatively useless PR on OP's fork with the one line change. Could really use this. |
|
Surely this should be the default behaviour anyway? The package option is used for build/deploy. Surely in "offline" mode everyone expects this to be reading src files? |
Co-authored-by: nponeccop <andy.melnikov@gmail.com>
|
I've neglected this PR as we're migrating all our services to AWS SAM. Is anyone else still wanting this feature? If there's still interest and maintainers are ok with the general approach, I'm happy to do work to get this over the finish line. |
dnalborczyk
force-pushed
the
master
branch
2 times, most recently
from
d5ea86d
to
22fd667
Compare
dnalborczyk
force-pushed
the
master
branch
2 times, most recently
from
fdd1699
to
51a30e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is helpful for projects not yet ready or able to run the
project using the artifact. Defaults to false. If
ignorePackageArtifact: trueis added to the serverless.ymlcustom.serverless-offline configuration section, the source files will
be used to run the offline lambda.