fixed hanging when python raises exception or return nothing #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, could you make sure the test pass? Thanks @ALOHACREPES345 |
|
@dherault I revised newly added test cases. These are similar to |
|
Hello. Just ran into this problem in 12.0.4 and was pretty confused. Should this ticket be reopened because the PR was ultimately reverted? 2b5a2d7 |
|
Hello, sorry to dig a 2 years issue but I think I also have this issue in @dherault by any chance, do you remember why it was reverted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #1089
added error handling if invoked python raised exception
close #1366
since python returns
null objectwhen nothing returned from invoked code, current js code mistakenly recognizes python is still running even if it's finished.And also, when python returns
"", current js code misunderstand. (Since js recognize""as false)Motivation and Context
#1089
#1366
How Has This Been Tested?
manual testing with using Sample Code in #1366.
Case A: with current code.
Case B: with fixed code.
Screenshots (if appropriate):