chore: remove unused portfinder dependency #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The portfinder dependency appears to be unused. It is the lone source of an npm audit warning on end-user installation. This change removes it.
|
Thanks for your first contribution @Trott. I like your GitHub profile 👍 |
|
I realize this may already be planned, but just in case not, a new release with this in it would be great, so that we can install it and remove warnings in GitHub interfaces and from |
|
It's in the shop :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the unused portfinder dependency.
Motivation and Context
The portfinder dependency is the lone source of an
npm auditwarning on end-user installation. This change fixes that problem.How Has This Been Tested?
I ran
npm teston the current master branch and on this feature branch and got the same results. I also did agrepforportfinderthroughout the code base and it only appeared inpackage.jsonone time, in the list of dependencies.