Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #715 Fix expression validator #717

Merged
merged 1 commit into from Jun 23, 2019
Merged

Fix #715 Fix expression validator #717

merged 1 commit into from Jun 23, 2019

Conversation

alebianco
Copy link

Escape identity validator expression;
Do not require grouping and return original token;

Escape identity validator expression;
Do not require grouping and return original token;
@dherault
Copy link
Owner

Thanks for the PR @alebianco
The new behavior is too divergent from the old one I think,
Before the authorization was matchedAuthorization[1] and after simply authorization
What about the parts in authorization we don't want, trimmed by the regex selector?

@alebianco
Copy link
Author

Yes it is a noticeable change, I didn't find any test that specifically cover this behaviour but I suspect there will be users out there leveraging it.

I double checked the AWS documentation (I don't know much of the other cloud providers serverless covers) and nowhere it says that the expression is/can be used to manipulate the token. It only verifies that the token matches the expression and then forwards the full token to the handler, if any modification is needed it can be done there.

I guess the point is to being the offline experience as close as possible to what will happen online once the authenticator is deployed.

Obviously I'm open to discussion and suggestions

@dherault dherault merged commit 11a58b8 into dherault:master Jun 23, 2019
@dherault
Copy link
Owner

v5.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants