close connection on error in $connect action handler #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frsechet
force-pushed
the
fix/aws-difference
branch
from
595ff90
to
b83c123
Compare
|
force-pushed to rebase because of linting issue |
dherault
approved these changes
Jul 2, 2019
|
@dherault what is needed in order to merge? Maybe some approval from @dnalborczyk? |
|
Sorry work happened between my review and now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error occurs in the $connect action handler, AWS does not let the connection be established. In order to mimic that behaviour, let's close the connection if the $connect handler throws.
see #711 (comment)