New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sympy-based helpers for "exact" representations #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For beginners, the first functions is a ``to_symbolic()`` helper.
Also adding full unit test coverage for `_symbolic.py`.
dhermes
changed the title
Adding
Add sympy-based helpers for "exact" representations
Jan 10, 2020
bezier[full]
extra, which includes SciPy and SymPy.In the process, also adding `sympy` as a dependency for `nox -s cover` session.
In the process, modified `curve_as_polynomial()` so that it also returned the `s` value used. This is to protect `curve.py` from having to know too much about SymPy.
In the process, modified `surface_as_polynomial()` so that it also returned the `s` and `t` values used. This is to protect `surface.py` from having to know too much about SymPy.
They were left incomplete while focusing on unit tests.
Also: - Tried to use all past tense in `latest.rst` - Fixed bad Sphinx references to SymPy types - Slightly changed wording / order in `implicitize()` docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157.