Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sympy-based helpers for "exact" representations #164

Merged
merged 14 commits into from Jan 10, 2020
Merged

Conversation

dhermes
Copy link
Owner

@dhermes dhermes commented Jan 10, 2020

Fixes #157.

For beginners, the first functions is a ``to_symbolic()`` helper.
Also adding full unit test coverage for `_symbolic.py`.
@dhermes dhermes changed the title Adding bezier[full] extra, which includes SciPy and SymPy. Add sympy-based helpers for "exact" representations Jan 10, 2020
In the process, also adding `sympy` as a dependency for
`nox -s cover` session.
In the process, modified `curve_as_polynomial()` so that it also
returned the `s` value used. This is to protect `curve.py`
from having to know too much about SymPy.
In the process, modified `surface_as_polynomial()` so that it also
returned the `s` and `t` values used. This is to protect `surface.py`
from having to know too much about SymPy.
They were left incomplete while focusing on unit tests.
Also:

- Tried to use all past tense in `latest.rst`
- Fixed bad Sphinx references to SymPy types
- Slightly changed wording / order in `implicitize()` docstrings
@dhermes dhermes merged commit dc5e3d7 into master Jan 10, 2020
@dhermes dhermes deleted the issue-157 branch January 10, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sympy-based helpers for "exact" representations
1 participant