New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BEZ_
prefix for exported C ABI names
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done via: ``` git grep -l "name='" -- '*.f90' | xargs sed -i '' s/"name='"/"name='BEZ_"/g git grep -l "name='" -- '*.f90' | xargs sed -i s/"name='"/"name='BEZ_"/g ``` This was an automated change, will be followed up by hand-written changes to all references to these ABI procedures.
(Still need to run `clang-format` on these, it is not yet installed on my laptop and I am currently offline.)
- Updated some Sphinx references with `BEZ_` prefix - Fixed an oversight in `example_locate_point_curve` - Fixed an old reference to `example_curve_specialize.c` (now is a reference to `example_specialize_curve.c`) - Change `-I src/fortran/include/` line to use `...` to indicate that path is not in the same directory as the `example*.c` files
I introduced this in dc58f0a, but commited it with `[ci skip]`. (I should never use `ci skip`, I've learned that lesson before.)
Not sure why new builds didn't get kicked off for Travis or CircleCI |
I'm going to merge this in hopes of triggering the correct builds on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166.