Skip to content

Commit

Permalink
Updating docstring and failing tests from upstream.
Browse files Browse the repository at this point in the history
  • Loading branch information
dhermes committed Dec 9, 2015
1 parent c838b22 commit 128219a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions gcloud_bigtable/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ def create(self, initial_split_keys=None, timeout_seconds=None):
A create request returns a
:class:`._generated.bigtable_table_data_pb2.Table` but we don't use
this response. The proto definition allows for the inclusion of a
``current_operation`` in the response, but in example usage so far,
it seems the Bigtable API does not return any operation.
``current_operation`` in the response, but it does not appear that
the Cloud Bigtable API returns any operation.
:type initial_split_keys: list
:param initial_split_keys: (Optional) List of row keys that will be
Expand Down
9 changes: 6 additions & 3 deletions gcloud_bigtable/test_cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,8 @@ def test_create(self):
# Create expected_result.
op_id = 5678
op_begin = object()
expected_result = MUT.Operation('create', op_id, op_begin)
expected_result = MUT.Operation('create', op_id, op_begin,
cluster=cluster)

# Perform the method and check the result.
timeout_seconds = 578
Expand Down Expand Up @@ -539,7 +540,8 @@ def test_update(self):
# Create expected_result.
op_id = 5678
op_begin = object()
expected_result = MUT.Operation('update', op_id, op_begin)
expected_result = MUT.Operation('update', op_id, op_begin,
cluster=cluster)

# We must create the cluster object with the client passed in.
timeout_seconds = 9
Expand Down Expand Up @@ -615,7 +617,8 @@ def test_undelete(self):
# Create expected_result.
op_id = 5678
op_begin = object()
expected_result = MUT.Operation('undelete', op_id, op_begin)
expected_result = MUT.Operation('undelete', op_id, op_begin,
cluster=cluster)

# Perform the method and check the result.
timeout_seconds = 78
Expand Down

0 comments on commit 128219a

Please sign in to comment.