Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for MCST-LCC compiler < 1.28 version #553

Merged
merged 1 commit into from Feb 6, 2024
Merged

Workaround for MCST-LCC compiler < 1.28 version #553

merged 1 commit into from Feb 6, 2024

Conversation

r-a-sattarov
Copy link
Contributor

@r-a-sattarov r-a-sattarov commented Feb 1, 2024 •
edited

After 6f35ce0 commit compilation on mcst-lcc became problematic (compiler does not support __builtin_alloca_with_align). Added workaround for < 1.28 version.
Ref: http://mcst.ru/lcc

@r-a-sattarov
Workaround for MCST-LCC compiler < 1.28 version
784bf42 
mcst-lcc < 1.28 does not support __builtin_alloca_with_align()
Ref: http://mcst.ru/lcc
@DanielGibson DanielGibson merged commit 6ed10c1 into dhewm:master Feb 6, 2024
@DanielGibson
Copy link
Member

thanks!

@r-a-sattarov r-a-sattarov deleted the mcst-lcc-workaround branch February 6, 2024 18:49
@DanielGibson
Copy link
Member

I just found out that __builtin_alloca_with_align() is generally broken (memory might be released at end of block instead of end of function), so I removed it for all platforms.

Can you confirm that the regular __builtin_alloca() is supported by all versions of MSCT-LCC, or was that also only added in 1.28?

@r-a-sattarov
Copy link
Contributor Author

Can you confirm that the regular __builtin_alloca() is supported by all versions of MSCT-LCC, or was that also only added in 1.28?

Yep, based on the output of CE, this should work in any version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ursoft ursoft ursoft approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-a-sattarov @DanielGibson @ursoft