Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates LESS Version of Skeleton #194

Closed
wants to merge 1 commit into from
Closed

Creates LESS Version of Skeleton #194

wants to merge 1 commit into from

Conversation

WhatsNewSaes
Copy link

GRID:

  • Added LESS logic so that grid columns are calculated from the total
    width of the container

VARIABLES:

  • Hooked up color variables to fonts, buttons, border, backgrounds

BREAKPOINTS:

  • defined breakpoints by variables.

GRUNT:

  • Grunt will watch the less file and any time there is a change saved it
    will compile to the css/skeleton.css file.

GRID:
- Added LESS logic so that grid columns are calculated from the total
width of the container

VARIABLES:
Hooked up color variables to fonts, buttons, border, backgrounds

BREAKPOINTS:
defined breakpoints by variables.

GRUNT:
Grunt will watch the less file and any time there is a change saved it
will compile to the css/skeleton.css file.
@luisrudge
Copy link

@WhatsNewSaes nice! YOu did it first! Please follow discussions here and here.
Can you setup aa Skeleton-less repo? I think that would be awesome and you can make a PR to the readme pointing to your less version.

@WhatsNewSaes
Copy link
Author

Awesome!

Currently I have it in a forked repo here. https://github.com/whatsnewsaes/LESS-version-of-skeleton. Maybe it just stays there and @dhg just links to the forked repo on his site / readme? Not totally sure what you mean about the PR / readme though...

@deeve007
Copy link

Yes, keep it there. It should be a fork or a new repo (as you have) of Skeleton, not the main repo.

@luisrudge
Copy link

@WhatsNewSaes can you rename to something like "Skeleton-less"?
Then you should do a PR over the Readme file, adding your repo info like "checkout the less version on this repo"

@deeve007
Copy link

Agree with @luisrudge

@dhg dhg added the feature label Dec 11, 2014
@walterdavis
Copy link

boneless?

:)

Walter

On Dec 11, 2014, at 11:53 AM, Luís Rudge notifications@github.com wrote:

@WhatsNewSaes can you rename to something like "Skeleton-less"?
Then you should do a PR over the Readme file, adding your repo info like "checkout the less version on this repo"


Reply to this email directly or view it on GitHub.

@luisrudge
Copy link

Please no. Skeleton-less should be ok

@WhatsNewSaes
Copy link
Author

@luisrudge, you go it -- #201

@Mause
Copy link

Mause commented Dec 12, 2014

I would love boneless if only for the doctor who reference :P

@luisrudge
Copy link

awesome!

@dhg
Copy link
Owner

dhg commented Dec 12, 2014

This is incredible. I have a hectic day, but promise I will dig into this asap and provide some feedback. I'm noodling on the best place to provide extensions/pseudo-official forks. The README might be right, but so might some place in the docs.

I'll get back to everyone shortly!

@sondr3
Copy link

sondr3 commented Dec 14, 2014

You could potentially also make an organisation for Skeleton and put the officially approved forks in it.

@luisrudge
Copy link

Yeah. I prefer that option, since the ports would be "official". But, this comes with a higher responsability for the maintainers. It HAS to be synced all the times.

@dhg
Copy link
Owner

dhg commented Dec 16, 2014

Alright, so here's the status! I just pushed an update to the docs with a link to "extensions" under the "more" navigation. That (as with all the other thinks there), just pushes to the README on github with links/explanation about the LESS/SASS repos @WhatsNewSaes put together.

For now, since I don't have time to really dig into them I'm branding them as "unofficial" releases. A "use at your own risk" situation. I would very much like to create an organization and create official LESS/SASS versions, but for now I'm focusing on just making v2.0 the best it can be. When I'm really happy with the state of 2.0 and confident it won't be changing (except for the occasional bugfix), I will take the time to really dive and and work with @WhatsNewSaes to make it all official and amazing!

@WhatsNewSaes - I just dropped v2.0.2 which changed the grid selectors, some index.html meta tags, and a handful of other things (see changelog notes). If you'd be up for updating the LESS/SASS versions that would be incredible. If not, I can try to get a PR open in the next week or so (though I have a lot of other personal commitments and work so it might take a little).

Thanks everyone! Going to close this for now since these are linked up in the docs and readme. In the future I'd like to surface these more in actual docs, but this is a good step until we have those official versions.

@luisrudge
Copy link

Awesome, @dhg! Thanks for everything!

@WhatsNewSaes
Copy link
Author

This is great. I'll look into getting them up to date soon. Thanks @dhg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants