Reduce change detection cycles #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
commented
Jun 13, 2023
Comment on lines
-10
to
-11
| "dependencies": { | ||
| "tslib": "^2.3.1" |
There was a problem hiding this comment.
Removed because it's added automatically by ng-packagr when the library is being built.
|
@dhilt I was having troubles to fix unit tests locally, there're lots of them tho. Could you help me fixing them? |
|
@arturovt This looks very interesting, thanks for PR! Give me a few days for review. |
Merged
|
@arturovt ngx-ui-scroll v3.1.0 is released, it contains your updates Thanks for your contribution, it seems super relevant and even led to some changes in the core lib. |
|
Thank you @dhilt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.