Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Husky and Prettier #339

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Setup Husky and Prettier #339

merged 6 commits into from
Jun 20, 2023

Conversation

arturovt
Copy link
Contributor

I din't run prettier on workspace files. Maybe you @dhilt would want to re-visit Prettier rules.

@dhilt
Copy link
Owner

dhilt commented Jun 17, 2023

@arturovt We are in 1 step from merging this PR, but I have a problem when trying to format the source code. I use the following script

    "format": "prettier --write \"scroller/**/*.ts\" \"demo/**/*.{ts,html,css,json}\" \"tests/**/*.{ts,css,json}\"",

and get the following error

✖ npm run lint:

D:\dev\dhilt\arturovt\ngx-ui-scroll\demo\app\demos.ts
  13:1  error  This line has a length of 130. Maximum allowed is 120  max-len

May I ask you to have a look, fix this last issue, run the above script (there will be more than 100 files changed) and commit the result?

@dhilt dhilt merged commit 602b41f into dhilt:master Jun 20, 2023
2 checks passed
@arturovt arturovt deleted the husky branch June 21, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants