Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 16 #341

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Upgrade to Angular 16 #341

merged 7 commits into from
Jul 4, 2023

Conversation

arturovt
Copy link
Contributor

@arturovt arturovt commented Jun 16, 2023

Note: I had to move tests from workspace/tests to workspace/scroller/src/tests. This was done because Angular resolves spec files relatively different starting from 14 version.

src/builders/karma/find-tests-plugin.js has the following:

const specFiles = await findTests(include, exclude, workspaceRoot, projectSourceRoot);

Which means .spec.ts files are searched automatically relatively to projectSourceRoot, which is workspace/scroller/src.

@dhilt dhilt changed the base branch from master to angular-16 July 4, 2023 17:32
@dhilt dhilt merged commit 82eb06e into dhilt:angular-16 Jul 4, 2023
1 of 2 checks passed
@dhilt
Copy link
Owner

dhilt commented Jul 4, 2023

@arturovt I didn't want to pin new versions of the lib to Angular 16+ because this would be a breaking change, so I decided to extract lib/demo/tests projects keeping their own dependency lists separate. I would agree that my current approach is not the best, perhaps it can be improved in the future.

Anyway, thanks for this big contribution! If you have time, maybe you can look at my updates in your ssr PR: #342.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants