Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating a machine docker-machine-kvm doesn't try to start the network #12

Open
vikstrous opened this issue Feb 24, 2016 · 1 comment

Comments

@vikstrous
Copy link

It would be nice if one doesn't need to manually start the network after a fresh install of libvirt and before using it with docker-machine.

@devurandom
Copy link

Coming from kubernetes/minikube#828, I had a look at https://github.com/dhiltgen/docker-machine-kvm/blob/master/kvm.go#L284 and compared that with my observation: I see two networks in virt-manager: default and docker-machines. docker-machines was set to auto start and was active when I looked at it. default was neither active nor set to auto start.

From the code it appears that the kvm-network (aka external network, default) is handled slightly differently from the private network (docker-machines). Thus I assume this issue can be fixed by placing the calls to SetAutoStart(true) and Create() (after LookupNetworkByName(...)) also in validateNetwork(...), just like they are present in validatePrivateNetwork()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants