fix: remove "required" binding from Deployable bool field #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Deployable bool field is `false`, the validation from the "required" tag will fail, as it's considered the zero-value for bools. In our case both `true` and `false` are valid, so there's no need to use the "required" tag. go-playground/validator#713
tonsV2
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that if the Deployable bool field is
false, the validation from the "required" tag will failas it's considered the zero-value for bools. In our case both
trueandfalseare valid, so there's no need to use the "required" tag.I've also handled the duplicated key error when creating a
group, but I'm not sure how to distinguish between duplicatedHostnameandName. Any ideas?