-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add pwa to plugins #746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhis2-bot
added a commit
that referenced
this pull request
Sep 19, 2022
# [10.1.0-alpha.5](v10.1.0-alpha.4...v10.1.0-alpha.5) (2022-09-19) ### Features * **cli:** add pwa to plugins; fix plugin build details ([#746](#746)) ([fd920a4](fd920a4))
🎉 This PR is included in version 10.1.0-alpha.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Oct 20, 2022
# [10.2.0-alpha.1](v10.1.0...v10.2.0-alpha.1) (2022-10-20) ### Bug Fixes * **cli:** improve plugin builds ([#749](#749)) ([b3b317c](b3b317c)) * add missing webpack dependencies to cli package ([9e58c58](9e58c58)) * **cli:** update webpack plugin options ([d084b44](d084b44)) * casing ([ff5aa6b](ff5aa6b)) * handle webpack errors as described in https://webpack.js.org/api/node/\#error-handling ([c557534](c557534)) * plugin placeholder ([1eea12c](1eea12c)) ### Features * **cli:** add pwa to plugins; fix plugin build details ([#746](#746)) ([fd920a4](fd920a4)) * include plugin launch path plugin.html in built manifests [LIBS-346] ([#745](#745)) ([8843f6b](8843f6b)) * **adapter:** don't render headerbar for plugins ([4ac6d54](4ac6d54)) * **cli:** add webpack config for JS and CSS ([a04b7c6](a04b7c6)) * **cli:** add webpack config for JS and CSS ([cec6339](cec6339)) * **cli:** create plugin entrypoint wrapper during compilation ([8e4dbff](8e4dbff)) * **cli:** enable split chunks optimisation in webpack config ([e8ebcbf](e8ebcbf)) * **cli:** plugin start script ([9fea158](9fea158)) * **cli:** setup css minimiser webpack plugin ([3f1b1f2](3f1b1f2)) * **cli:** setup define webpack plugin ([5d8f374](5d8f374)) * **cli:** setup htmlwebpackplugin ([202225c](202225c)) * **cli:** setup ignore webpack plugin for moment.js ([223b191](223b191)) * **cli:** setup terser webpack plugin ([2693258](2693258)) * webpack config for plugin ([3e4275c](3e4275c)) * **cli:** support plugin entrypoint when validating entrypoints ([04ece0a](04ece0a))
🎉 This PR is included in version 10.2.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Nov 30, 2022
# [10.2.0](v10.1.6...v10.2.0) (2022-11-30) ### Bug Fixes * **cli:** improve plugin builds ([#749](#749)) ([b3b317c](b3b317c)) * add missing webpack dependencies to cli package ([9e58c58](9e58c58)) * **cli:** update webpack plugin options ([d084b44](d084b44)) * casing ([ff5aa6b](ff5aa6b)) * handle webpack errors as described in https://webpack.js.org/api/node/\#error-handling ([c557534](c557534)) * plugin placeholder ([1eea12c](1eea12c)) ### Features * **cli:** add pwa to plugins; fix plugin build details ([#746](#746)) ([fd920a4](fd920a4)) * include plugin launch path plugin.html in built manifests [LIBS-346] ([#745](#745)) ([8843f6b](8843f6b)) * **adapter:** don't render headerbar for plugins ([4ac6d54](4ac6d54)) * **cli:** add webpack config for JS and CSS ([a04b7c6](a04b7c6)) * **cli:** add webpack config for JS and CSS ([cec6339](cec6339)) * **cli:** create plugin entrypoint wrapper during compilation ([8e4dbff](8e4dbff)) * **cli:** enable split chunks optimisation in webpack config ([e8ebcbf](e8ebcbf)) * **cli:** plugin start script ([9fea158](9fea158)) * **cli:** setup css minimiser webpack plugin ([3f1b1f2](3f1b1f2)) * **cli:** setup define webpack plugin ([5d8f374](5d8f374)) * **cli:** setup htmlwebpackplugin ([202225c](202225c)) * **cli:** setup ignore webpack plugin for moment.js ([223b191](223b191)) * **cli:** setup terser webpack plugin ([2693258](2693258)) * webpack config for plugin ([3e4275c](3e4275c)) * **cli:** support plugin entrypoint when validating entrypoints ([04ece0a](04ece0a))
🎉 This PR is included in version 10.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the plugin and the app are sharing the same config -- this feels weird, but seems to work.
I'm noticing there are two versions of workbox in
yarn.lock
because it looks like there are strict version dependencies between the different workbox sub-packages -- I'll look into this too