Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Provider instead of DataProvider #163

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Nov 14, 2019

We mistakenly only rendered a DataProvider, which meant that the useContext hook returned invalid information (baseUrl: '..') instead of being initialized by the app shell.

@amcgee amcgee requested a review from varl November 14, 2019 11:29
@netlify
Copy link

netlify bot commented Nov 14, 2019

Deploy preview for dhis2-app-platform canceled.

Built with commit 9ee775d

https://app.netlify.com/sites/dhis2-app-platform/deploys/5dcd3a9584ac5d00097417dc

@amcgee amcgee merged commit ece9424 into master Nov 14, 2019
@amcgee amcgee deleted the fix/provider-not-dataprovider branch November 14, 2019 12:14
dhis2-bot added a commit that referenced this pull request Nov 14, 2019
## [1.5.9](v1.5.8...v1.5.9) (2019-11-14)

### Bug Fixes

* use Provider instead of DataProvider ([#163](#163)) ([ece9424](ece9424))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 1.5.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants