Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't generate useless empty files if no translatable strings found #270

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Jan 17, 2020

Fixes #268

This also cleans up some of the i18n code that was ported from the d2-i18n-[extract|generate] libraries

@amcgee amcgee requested a review from varl January 17, 2020 14:57
Copy link
Contributor

@varl varl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks! 🥂

@varl varl merged commit 27a8ab8 into master Jan 17, 2020
@varl varl deleted the fix/noop-i18n branch January 17, 2020 15:26
dhis2-bot added a commit that referenced this pull request Jan 17, 2020
## [3.2.2](v3.2.1...v3.2.2) (2020-01-17)

### Bug Fixes

* don't generate useless empty files if no translatable strings found ([#270](#270)) ([27a8ab8](27a8ab8))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

In libraries that has no i18n, the directories are still created
3 participants