-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate d2.config.json from d2.config.js #471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short and sweet.
Question: will it be more common to include or omit properties in the json output?
I think it should be rare to do either.... the |
@varl does that seem reasonable? Should we explicitly construct the |
Some additions we might consider... |
Some exclusions we might consider... |
I think it's reasonable to just delete the key now, and when we need a more sophisticated schema for the json, we can create a function that constructs the |
# [5.4.0](v5.3.0...v5.4.0) (2020-10-19) ### Features * generate d2.config.json from d2.config.js ([#471](#471)) ([2046074](2046074))
🎉 This PR is included in version 5.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This generates a new config file
d2.config.json
from the compiled application config (merge ofpackage.json
andd2.config.js
). The.json
file is placed at the root of the application output, next tomanifest.webapp
, which it will eventually replace. The data in this config file is necessary to enforce immutable application slugs, parse version numbers, and other things when publishing to the App Hub.Here is a sample
d2.config.json
output generated fromexamples/simple-app
: