Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable publishing login_app apps #837

Merged
merged 1 commit into from
Mar 21, 2024
Merged

feat: enable publishing login_app apps #837

merged 1 commit into from
Mar 21, 2024

Conversation

kabaros
Copy link
Contributor

@kabaros kabaros commented Mar 21, 2024

No description provided.

@kabaros kabaros requested a review from tomzemp March 21, 2024 11:22
@kabaros kabaros added the alpha label Mar 21, 2024
tomzemp
tomzemp approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@tomzemp tomzemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
There's also already a helper function for this, so requiring that (const { isApp } = require('../lib/parseConfig')) and then using it if (!isApp(appConfig.type)) { would also work

@kabaros kabaros merged commit 93093ca into alpha Mar 21, 2024
6 checks passed
@kabaros kabaros deleted the enable-login-apps branch March 21, 2024 12:13
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.6.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomzemp tomzemp tomzemp approved these changes

Assignees
No one assigned
Labels
alpha released on @alpha
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kabaros @dhis2-bot @tomzemp