Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add generic result type to oncomplete param #1350

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

Birkbjo
Copy link
Member

@Birkbjo Birkbjo commented Jun 16, 2023


Key features

  1. Fixes typing for onComplete data-param

Description

Adds a TQueryResult type for onComplete in QueryOptions


@Birkbjo Birkbjo changed the title fix(types): add genereric result type to oncomplete param fix(types): add generic result type to oncomplete param Jun 16, 2023
@Birkbjo Birkbjo merged commit a069603 into master Jun 19, 2023
9 checks passed
@Birkbjo Birkbjo deleted the fix/oncomplete-types branch June 19, 2023 09:20
dhis2-bot added a commit that referenced this pull request Jun 19, 2023
## [3.9.4](v3.9.3...v3.9.4) (2023-06-19)

### Bug Fixes

* **types:** add generic result type to oncomplete param ([#1350](#1350)) ([a069603](a069603))
@dhis2-bot
Copy link
Contributor

amcgee pushed a commit that referenced this pull request Aug 22, 2023
## [3.9.4](v3.9.3...v3.9.4) (2023-06-19)

### Bug Fixes

* **types:** add generic result type to oncomplete param ([#1350](#1350)) ([a069603](a069603))
dhis2-bot added a commit that referenced this pull request Aug 22, 2023
# [3.10.0-alpha.3](v3.10.0-alpha.2...v3.10.0-alpha.3) (2023-08-22)

### Bug Fixes

* **connection-status:** responsiveness to online events [LIBS-497] ([#1348](#1348)) ([91a3d4d](91a3d4d))
* **types:** add generic result type to oncomplete param ([#1350](#1350)) ([a069603](a069603))
* [DHIS2] Type generic T = QueryResult to useDataQuery ([#1297](#1297)) ([7c5c083](7c5c083))
* account for daylight savings time [LIBS-490] ([06eaa5d](06eaa5d))
* account for daylight savings time [LIBS-490] [#1345](#1345) ([fb00533](fb00533))
* add test for when time zones are the same [LIBS-490] ([7911f8b](7911f8b))
@dhis2-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants