Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): test out circular dependency as infinite install loop cause #1378

Closed
wants to merge 1 commit into from

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Apr 5, 2024

Edit: actually, I don't think a circular dependency is causing the loop that ends with multi-calendar-dates and starts with cli-app-scripts and indicates a version conflict for React. After alpha.1 of app-runtime where the cli-app-scripts version conflict was fixed, app-runtime still has a dev dependency on cli-app-scripts, but no longer loops. @dhis2/multi-calendar-dates and @dhis2/ui both have only a dev dependency on cli-app-scripts as well (not a peer dep like app-runtime had before alpha.1), so those wouldn't be expected to loop because of that dependency

Either peer dependency version conflicts or circular dependencies can cause infinite loops during the NPM install -- adding this circular dependency but not a version conflict will test if circular dependencies do indeed cause loops, or if it's just version conflicts

Part of LIBS-587

@KaiVandivier KaiVandivier marked this pull request as draft April 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant