Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [DHIS2-17052] Unrelated error message on no TETs #3605

Merged

Conversation

eirikhaugstulen
Copy link
Contributor

Tech-summary:

  • Add a more relevant dropdown message when there are no TETs

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review April 17, 2024 07:56
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner April 17, 2024 07:56
@karolinelien
Copy link
Contributor

I get @simonadomnisoru's point very much, but I think this is such a peripheral use case where if the user does go to that page, it is probably better that it is clear what the issue is. If we say they don't have access to create but they do have access to create in event programs for example, this could be misleading. So I think I would just go for @eirikhaugstulen's technical copy here.

…unrelated-error-message-on-no-tets

# Conflicts:
#	i18n/en.pot
Copy link

@eirikhaugstulen eirikhaugstulen merged commit 6a38ae3 into master May 30, 2024
37 of 42 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/fix/DHIS2-17052-unrelated-error-message-on-no-tets branch May 30, 2024 08:59
dhis2-bot added a commit that referenced this pull request May 30, 2024
## [100.68.15](v100.68.14...v100.68.15) (2024-05-30)

### Bug Fixes

* [DHIS2-17052] Unrelated error message on no TETs ([#3605](#3605)) ([6a38ae3](6a38ae3))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.68.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.1,2.40.4,2.39.6,2.38.7 versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

7 participants