Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add plugin documentation #3636

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

eirikhaugstulen
Copy link
Contributor

This PR adds the plugin developer documentation. This documentation will be hosted on the developers portal.

@eirikhaugstulen
Copy link
Contributor Author

PR in the developers portal: dhis2/developer-portal#152

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review May 10, 2024 07:20
@eirikhaugstulen eirikhaugstulen requested review from a team as code owners May 10, 2024 07:20
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
In the Github preview for the newly added files there are some syntaxes that are not displayed correctly (warnings, tips, images, etc.). I suggested some alternatives using regular markdown syntax, but I'm not sure if this is a cause for concern or if it will compile and display correctly in the developer portal.
Thanks!


1. Log in to your DHIS2 system and open the data store management app. It should look something like this.

<img src={require("./resources/data-store-management-app.png").default} alt="Data store management app" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images in this file don't seem to be displayed (is this related to properly compiling the .mdx files?).
One way to make it work is to use Github's recommended format for images. Something like this should work ![Data Store Management App](./resources/data-store-management-app.png)

# Getting started

---
:::warning Experimental feature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The :::warning syntax is not being displayed. One way to make it work is to use Github's recommended format for alerts

@@ -0,0 +1,292 @@
import Tabs from '@theme/Tabs';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSX syntax in this .mdx file does not appear to display correctly. Are there any packages or configurations missing to get it working?

@eirikhaugstulen
Copy link
Contributor Author

Hey again! Thanks for the review @simonadomnisoru.

I actually ended up rewriting most of the documentation as it was not great. I'm aware that the preview functionality in GitHub does not really deal with mdx and docusaurus syntax very well, but you can inspect the final result here:
https://deploy-preview-152--dhis2-developer-portal.netlify.app/docs/capture-plugins/developer/getting-started

It does seem to be parsed and displayed correctly here! Please have a look and get back to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants