feat: add fullscreen option to visualization items [DHIS2-9879] #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
approved these changes
Dec 14, 2020
| const el = document.querySelector(this.itemDomElSelector) | ||
| if (el?.requestFullscreen) { | ||
| el.onfullscreenchange = this.handleFullscreenChange | ||
| } |
There was a problem hiding this comment.
I'm wondering if we should handle the error case with onfullscreenerror
dhis2-bot
added a commit
that referenced
this pull request
Jan 5, 2021
# [31.4.0](v31.3.1...v31.4.0) (2021-01-05) ### Features * add fullscreen option to visualization items [DHIS2-9879] ([#1358](#1358)) ([746d7b0](746d7b0)), closes [cypress-io/cypress#7776](cypress-io/cypress#7776)
|
🎉 This PR is included in version 31.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Upcoming refactor:
document.querySelector. For best practice, this should instead be done with refs, but using refs would have required a somewhat big refactor. I would prefer to do this refactor separately since the testing scope is larger.Other: