fix: changed incorrect prop types and tests (#372)

* fix: changed incorrect prop types and tests * fix: upgraded to Analytics v2.6.2
dhis2 · Nov 15, 2019 · c96ac09 · c96ac09
1 parent 22c36e2
commit c96ac09
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 10 deletions.
diff --git a/packages/app/i18n/en.pot b/packages/app/i18n/en.pot
@@ -5,8 +5,8 @@ msgstr ""
 "Content-Type: text/plain; charset=utf-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"POT-Creation-Date: 2019-11-11T14:45:11.552Z\n"
-"PO-Revision-Date: 2019-11-11T14:45:11.552Z\n"
+"POT-Creation-Date: 2019-11-15T12:12:19.215Z\n"
+"PO-Revision-Date: 2019-11-15T12:12:19.215Z\n"
 
 msgid "Rename successful"
 msgstr ""
@@ -297,6 +297,9 @@ msgstr ""
 msgid "Chart options"
 msgstr ""
 
+msgid "Open as Map"
+msgstr ""
+
 msgid "Reporting rate"
 msgstr ""
 

diff --git a/packages/app/package.json b/packages/app/package.json
@@ -25,7 +25,7 @@
         "webpack-bundle-analyzer": "^3.0.3"
     },
     "dependencies": {
-        "@dhis2/analytics": "^2.6.0",
+        "@dhis2/analytics": "^2.6.2",
         "@dhis2/d2-i18n": "^1.0.6",
         "@dhis2/d2-ui-core": "^6.2.1",
         "@dhis2/d2-ui-file-menu": "^6.2.1",

diff --git a/packages/app/src/components/DimensionsPanel/__tests__/DimensionsPanel.spec.js b/packages/app/src/components/DimensionsPanel/__tests__/DimensionsPanel.spec.js
@@ -20,8 +20,12 @@ describe('The Dimensions component ', () => {
             dimensions: {},
             ui: {
                 layout: {},
+                type: '',
             },
             itemsByDimension: {},
+            dualAxisItemHandler: () => {},
+            axisItemHandler: () => {},
+            removeItemHandler: () => {},
         };
     });
 

diff --git a/packages/app/src/components/VisualizationTypeSelector/MenuItemIcon.js b/packages/app/src/components/VisualizationTypeSelector/MenuItemIcon.js
@@ -62,7 +62,7 @@ const MenuItemIcon = ({ iconType, style }) => {
 };
 
 MenuItemIcon.propTypes = {
-    iconType: PropTypes.string.isRequired,
+    iconType: PropTypes.string,
     style: PropTypes.object,
 };
 

diff --git a/packages/app/src/components/VisualizationTypeSelector/VisualizationTypeMenuItem.js b/packages/app/src/components/VisualizationTypeSelector/VisualizationTypeMenuItem.js
@@ -34,7 +34,7 @@ VisualizationTypeMenuItem.propTypes = {
     iconType: PropTypes.string,
     styles: PropTypes.object,
     label: PropTypes.string,
-    isSelected: PropTypes.Boolean,
+    isSelected: PropTypes.bool,
 };
 
 export default VisualizationTypeMenuItem;
diff --git a/packages/plugin/package.json b/packages/plugin/package.json
@@ -5,7 +5,7 @@
     "main": "./build/index.js",
     "license": "BSD-3-Clause",
     "dependencies": {
-        "@dhis2/analytics": "^2.6.0",
+        "@dhis2/analytics": "^2.6.2",
         "@material-ui/core": "^3.1.2",
         "lodash-es": "^4.17.11",
         "react": "^16.6.0",

diff --git a/yarn.lock b/yarn.lock
@@ -183,10 +183,10 @@
     react-beautiful-dnd "^10.1.1"
     styled-jsx "^3.2.1"
 
-"@dhis2/analytics@^2.6.0":
-  version "2.6.0"
-  resolved "https://registry.yarnpkg.com/@dhis2/analytics/-/analytics-2.6.0.tgz#81f8a37acf76ac606f27e22986665723e54587d8"
-  integrity sha512-aYnUXxefEeJFZNJcHULA4jwFwbHKUkjrP8qSi2UHuho6M5TJGqb1oQOPth8NuALlYtShmJcP3tG0lcABeS2lUA==
+"@dhis2/analytics@^2.6.2":
+  version "2.6.2"
+  resolved "https://registry.yarnpkg.com/@dhis2/analytics/-/analytics-2.6.2.tgz#10223103dbad456507cdc676184000c8b96b2375"
+  integrity sha512-9i0yXVeLeHF/p4M5giw+cL2q+tJHYSuXaIeTUWPUcDEe0/vTou3BWOqOMlLNWU+5EXoE1XnGu+1R9GI+pbpV4g==
   dependencies:
     "@dhis2/d2-i18n" "^1.0.4"
     "@dhis2/d2-ui-org-unit-dialog" "^6.3.0"