Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: working translations [v32] #1001

Merged
merged 5 commits into from
May 19, 2020
Merged

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented May 19, 2020

Part of fix for: https://jira.dhis2.org/browse/DHIS2-8638
Part of fix for: https://jira.dhis2.org/browse/DHIS2-8892

Changes are basically the same as for v33, with a few minor differences. Looking to have as little change surface area as possible

Copy link
Contributor

@martinkrulltott martinkrulltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested locally. Found 2 cases of yarn duplicates, as per comments below. Can be fixed with npx yarn-deduplicate --packages PACKAGENAME yarn.lock

yarn.lock Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@jenniferarnesen jenniferarnesen merged commit c32c623 into v32 May 19, 2020
@jenniferarnesen jenniferarnesen deleted the chore/complete-translations-v32 branch May 19, 2020 14:27
dhis2-bot added a commit that referenced this pull request Jun 8, 2020
# [32.1.0](v32.0.3...v32.1.0) (2020-06-08)

### Bug Fixes

* upgrade d2-ui dependencies for latest translations [v32] [DHIS2-8892] ([#1061](#1061)) ([6bc2f8c](6bc2f8c))
* **translations:** sync translations from transifex (v32) ([ff4839e](ff4839e))
* **translations:** sync translations from transifex (v32) ([bb026d0](bb026d0))
* **translations:** sync translations from transifex (v32) ([c15e3b6](c15e3b6))
* **translations:** sync translations from transifex (v32) ([0620c69](0620c69))
* @dhis2/analytics@2.4.9 ([4ed10df](4ed10df))
* allow : after bold and italic ([#314](#314)) ([59aed20](59aed20))
* changed height to min-height for the axes area ([#361](#361)) ([#366](#366)) ([5848460](5848460))
* d2-charts-api@32.0.9 ([27eff19](27eff19))
* deep check styles for changes ([#283](#283)) ([e76555c](e76555c))
* display 'and x others...' on tooltip (DHIS2-8753) v32 backport ([#945](#945)) ([0590fdf](0590fdf)), closes [#927](#927) [#925](#925)
* epi curve bug (v32) ([#529](#529)) ([2908206](2908206))
* epi curve bug v32 (v2) ([#530](#530)) ([de40d3d](de40d3d))
* Fetching analytics for analytical object with undefined aggregationType in plugin ([#232](#232)) ([bfe41b4](bfe41b4))
* Fetching analytics for year over year charts in plugin ([#231](#231)) ([16853ef](16853ef))
* manifest credentials bug in chrome ([#233](#233)) ([a0032e0](a0032e0))
* merge conflict ([#545](#545)) ([8e5f7aa](8e5f7aa))
* pie tooltip v32 ([#332](#332)) ([77b2628](77b2628))
* plugin - add deep checks to determine whether to redraw chart  ([#284](#284)) ([4b8837e](4b8837e))
* remove api.baseUrl duplicate ([#571](#571)) ([fafd58e](fafd58e))
* v32 backport, upgraded to Analytics v2.4.7 to support long dimension names (DHIS2-7932) ([#622](#622)) ([2cd524a](2cd524a))
* working translations [v32] ([#1001](#1001)) ([c32c623](c32c623))

### Features

* dual axis support ([#239](#239)) ([a50075c](a50075c))
* multiple org units support ([#333](#333)) ([6392efa](6392efa))

### Reverts

* Revert "fix: use lerna to share code instead of copying resources (#214)" (#216) ([de00b4f](de00b4f)), closes [#214](#214) [#216](#216)
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 32.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants