fix: reset app when New is clicked (v35) (DHIS2-9876) #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app should reset also when the URL does not change, like when a non-saved visualization is shown and New in the FileMenu is clicked. This used to work in 2.34. (cherry picked from commit 0dc16ed)
edoardo
changed the title
janhenrikoverland
approved these changes
Nov 19, 2020
This was referenced Dec 23, 2020
This was referenced Jan 26, 2021
dhis2-bot
added a commit
that referenced
this pull request
Mar 23, 2021
## [35.12.25](v35.12.24...v35.12.25) (2021-03-23) ### Bug Fixes * debounce DHIS2-10611 interpretations DHIS2-10625 ([#1670](#1670)) ([4c6f987](4c6f987)) * **translations:** sync translations from transifex (35.x) ([b730093](b730093)) * **translations:** sync translations from transifex (35.x) ([c86f8b3](c86f8b3)) * **translations:** sync translations from transifex (35.x) ([d0fb384](d0fb384)) * **translations:** sync translations from transifex (35.x) ([f9df3d5](f9df3d5)) * **translations:** sync translations from transifex (35.x) ([c9537f0](c9537f0)) * **translations:** sync translations from transifex (35.x) ([8c5df7c](8c5df7c)) * **translations:** sync translations from transifex (35.x) ([f0f3e07](f0f3e07)) * reset app when New is clicked (DHIS2-9876) ([#1470](#1470)) ([3d6a299](3d6a299)) * upgrade d2-ui dependencies to fix interpretations translations [v35] ([#1514](#1514)) ([3d18155](3d18155))
dhis2-bot
added a commit
that referenced
this pull request
Mar 24, 2021
## [35.12.25](v35.12.24...v35.12.25) (2021-03-24) ### Bug Fixes * bump Analytics to latest ([#1671](#1671)) ([d848cba](d848cba)) * debounce DHIS2-10611 interpretations DHIS2-10625 ([#1670](#1670)) ([4c6f987](4c6f987)) * **translations:** sync translations from transifex (35.x) ([b730093](b730093)) * **translations:** sync translations from transifex (35.x) ([c86f8b3](c86f8b3)) * **translations:** sync translations from transifex (35.x) ([d0fb384](d0fb384)) * **translations:** sync translations from transifex (35.x) ([f9df3d5](f9df3d5)) * **translations:** sync translations from transifex (35.x) ([c9537f0](c9537f0)) * **translations:** sync translations from transifex (35.x) ([8c5df7c](8c5df7c)) * **translations:** sync translations from transifex (35.x) ([f0f3e07](f0f3e07)) * reset app when New is clicked (DHIS2-9876) ([#1470](#1470)) ([3d6a299](3d6a299)) * upgrade d2-ui dependencies to fix interpretations translations [v35] ([#1514](#1514)) ([3d18155](3d18155))
dhis2-bot
added a commit
that referenced
this pull request
Mar 25, 2021
## [35.12.25](v35.12.24...v35.12.25) (2021-03-25) ### Bug Fixes * bump Analytics to latest ([#1671](#1671)) ([d848cba](d848cba)) * debounce DHIS2-10611 interpretations DHIS2-10625 ([#1670](#1670)) ([4c6f987](4c6f987)) * **translations:** sync translations from transifex (35.x) ([b730093](b730093)) * **translations:** sync translations from transifex (35.x) ([c86f8b3](c86f8b3)) * **translations:** sync translations from transifex (35.x) ([d0fb384](d0fb384)) * **translations:** sync translations from transifex (35.x) ([f9df3d5](f9df3d5)) * **translations:** sync translations from transifex (35.x) ([c9537f0](c9537f0)) * **translations:** sync translations from transifex (35.x) ([8c5df7c](8c5df7c)) * **translations:** sync translations from transifex (35.x) ([f0f3e07](f0f3e07)) * reset app when New is clicked (DHIS2-9876) ([#1470](#1470)) ([3d6a299](3d6a299)) * upgrade d2-ui dependencies to fix interpretations translations [v35] ([#1514](#1514)) ([3d18155](3d18155))
dhis2-bot
added a commit
that referenced
this pull request
Mar 26, 2021
## [35.12.25](v35.12.24...v35.12.25) (2021-03-26) ### Bug Fixes * bump Analytics to latest ([#1671](#1671)) ([d848cba](d848cba)) * debounce DHIS2-10611 interpretations DHIS2-10625 ([#1670](#1670)) ([4c6f987](4c6f987)) * fix download links for dataValueSet DHIS2-9789 v35 ([#1674](#1674)) ([394dd56](394dd56)) * **translations:** sync translations from transifex (35.x) ([b730093](b730093)) * **translations:** sync translations from transifex (35.x) ([c86f8b3](c86f8b3)) * **translations:** sync translations from transifex (35.x) ([d0fb384](d0fb384)) * **translations:** sync translations from transifex (35.x) ([f9df3d5](f9df3d5)) * **translations:** sync translations from transifex (35.x) ([c9537f0](c9537f0)) * **translations:** sync translations from transifex (35.x) ([8c5df7c](8c5df7c)) * **translations:** sync translations from transifex (35.x) ([f0f3e07](f0f3e07)) * reset app when New is clicked (DHIS2-9876) ([#1470](#1470)) ([3d6a299](3d6a299)) * upgrade d2-ui dependencies to fix interpretations translations [v35] ([#1514](#1514)) ([3d18155](3d18155))
dhis2-bot
added a commit
that referenced
this pull request
Mar 29, 2021
# [35.13.0](v35.12.24...v35.13.0) (2021-03-29) ### Bug Fixes * bump Analytics to latest ([#1671](#1671)) ([d848cba](d848cba)) * debounce DHIS2-10611 interpretations DHIS2-10625 ([#1670](#1670)) ([4c6f987](4c6f987)) * fix download links for dataValueSet DHIS2-9789 v35 ([#1674](#1674)) ([394dd56](394dd56)) * **translations:** sync translations from transifex (35.x) ([b730093](b730093)) * **translations:** sync translations from transifex (35.x) ([c86f8b3](c86f8b3)) * **translations:** sync translations from transifex (35.x) ([d0fb384](d0fb384)) * **translations:** sync translations from transifex (35.x) ([f9df3d5](f9df3d5)) * **translations:** sync translations from transifex (35.x) ([c9537f0](c9537f0)) * **translations:** sync translations from transifex (35.x) ([8c5df7c](8c5df7c)) * **translations:** sync translations from transifex (35.x) ([f0f3e07](f0f3e07)) * reset app when New is clicked (DHIS2-9876) ([#1470](#1470)) ([3d6a299](3d6a299)) * upgrade d2-ui dependencies to fix interpretations translations [v35] ([#1514](#1514)) ([3d18155](3d18155)) ### Features * minor bump ([#1681](#1681)) ([84dbac4](84dbac4))
dhis2-bot
added a commit
that referenced
this pull request
Mar 29, 2021
# [35.13.0](v35.12.24...v35.13.0) (2021-03-29) ### Bug Fixes * bump Analytics to latest ([#1671](#1671)) ([d848cba](d848cba)) * debounce DHIS2-10611 interpretations DHIS2-10625 ([#1670](#1670)) ([4c6f987](4c6f987)) * fix download links for dataValueSet DHIS2-9789 v35 ([#1674](#1674)) ([394dd56](394dd56)) * **translations:** sync translations from transifex (35.x) ([b730093](b730093)) * **translations:** sync translations from transifex (35.x) ([c86f8b3](c86f8b3)) * **translations:** sync translations from transifex (35.x) ([d0fb384](d0fb384)) * **translations:** sync translations from transifex (35.x) ([f9df3d5](f9df3d5)) * **translations:** sync translations from transifex (35.x) ([c9537f0](c9537f0)) * **translations:** sync translations from transifex (35.x) ([8c5df7c](8c5df7c)) * **translations:** sync translations from transifex (35.x) ([f0f3e07](f0f3e07)) * reset app when New is clicked (DHIS2-9876) ([#1470](#1470)) ([3d6a299](3d6a299)) * upgrade d2-ui dependencies to fix interpretations translations [v35] ([#1514](#1514)) ([3d18155](3d18155)) ### Features * minor bump ([#1681](#1681)) ([84dbac4](84dbac4)) * minor bump 2 ([e3475ae](e3475ae))
dhis2-bot
added a commit
that referenced
this pull request
Mar 29, 2021
# [35.13.0](v35.12.24...v35.13.0) (2021-03-29) ### Bug Fixes * bump Analytics to latest ([#1671](#1671)) ([d848cba](d848cba)) * debounce DHIS2-10611 interpretations DHIS2-10625 ([#1670](#1670)) ([4c6f987](4c6f987)) * fix download links for dataValueSet DHIS2-9789 v35 ([#1674](#1674)) ([394dd56](394dd56)) * **translations:** sync translations from transifex (35.x) ([b730093](b730093)) * **translations:** sync translations from transifex (35.x) ([c86f8b3](c86f8b3)) * **translations:** sync translations from transifex (35.x) ([d0fb384](d0fb384)) * **translations:** sync translations from transifex (35.x) ([f9df3d5](f9df3d5)) * **translations:** sync translations from transifex (35.x) ([c9537f0](c9537f0)) * **translations:** sync translations from transifex (35.x) ([8c5df7c](8c5df7c)) * **translations:** sync translations from transifex (35.x) ([f0f3e07](f0f3e07)) * reset app when New is clicked (DHIS2-9876) ([#1470](#1470)) ([3d6a299](3d6a299)) * upgrade d2-ui dependencies to fix interpretations translations [v35] ([#1514](#1514)) ([3d18155](3d18155)) ### Features * minor bump ([#1681](#1681)) ([84dbac4](84dbac4)) * minor bump 2 ([e3475ae](e3475ae))
|
🎉 This PR is included in version 35.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app should reset also when the URL does not change, like when a
non-saved visualization is shown and New in the FileMenu is clicked.
This used to work in 2.34.
(cherry picked from commit 0dc16ed)
See the original PR #1406 for more information.