fix: detect style changes from dashboard for re-rendering visualization #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
approved these changes
Mar 22, 2021
@edoardo I switched back to separate effects. Realized the problem was that I was using |
dhis2-bot
added a commit
that referenced
this pull request
Mar 22, 2021
## [35.20.22](v35.20.21...v35.20.22) (2021-03-22) ### Bug Fixes * detect style changes from dashboard for re-rendering visualization ([#1667](#1667)) ([ee6a7d0](ee6a7d0))
|
🎉 This PR is included in version 35.20.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jenniferarnesen
added a commit
that referenced
this pull request
Mar 23, 2021
…on (#1667) Key features: Visualizations in dashboard were not rerendering to fit the item size in the following situations: * item fullscreen * edit item resize * change screen width (e.g., switch to/from small screen) Description Dashboard and Data Visualizer apps have different approaches regarding visualization size and resizing. DV vis containers have display flex and use a counter that updates when the window is resized, to trigger a re-render of the visualization. In Dashboard, the container has a set width and height, which change on any of the above resizing scenarios. It does not use a counter. The new effect will end up being specific to dashboard, while the existing effect that responds to renderCounter will be specific to DV. A future improvement would possibly be to use the same mechanisms for both apps. But playing it safe for now, since we are in a hard freeze.
janhenrikoverland
pushed a commit
that referenced
this pull request
Mar 31, 2021
…on (#1667) Key features: Visualizations in dashboard were not rerendering to fit the item size in the following situations: * item fullscreen * edit item resize * change screen width (e.g., switch to/from small screen) Description Dashboard and Data Visualizer apps have different approaches regarding visualization size and resizing. DV vis containers have display flex and use a counter that updates when the window is resized, to trigger a re-render of the visualization. In Dashboard, the container has a set width and height, which change on any of the above resizing scenarios. It does not use a counter. The new effect will end up being specific to dashboard, while the existing effect that responds to renderCounter will be specific to DV. A future improvement would possibly be to use the same mechanisms for both apps. But playing it safe for now, since we are in a hard freeze.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key features
Description
Dashboard and Data Visualizer apps have different approaches regarding visualization size and resizing. DV vis containers have display flex and use a counter that updates when the window is resized, to trigger a re-render of the visualization. In Dashboard, the container has a set width and height, which change on any of the above resizing scenarios. It does not use a counter.
The new effect will end up being specific to dashboard, while the existing effect that responds to
renderCounterwill be specific to DV. A future improvement would possibly be to use the same mechanisms for both apps. But playing it safe for now, since we are in a hard freeze.Screenshots
(the video clips off the legend at the bottom, but it is actually visible)
dashboard.fs.mov