[WIP] Feature/multi drag dimensions #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ust one item less than causing scroll
|
This feature has been smoke tested and we will merge it for the sake of getting started on the new mono repo. Needs more testing before being released or added to d2-ui. |
|
🎉 This PR is included in version 33.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 32.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 9, 2020
This was referenced Jun 17, 2020
|
🎉 This PR is included in version 33.1.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: enable user to sort the selected items list by dragging multiple items at the same time. This feature should be available in the Dynamic Dimensions, Data Dimension, and Period Dimension dialogs. In order to share code/remove duplication, since Period Dimension is a d2-ui component, it was necessary to separate out the common functionality into a new shared component "Item Selector". This shared component is currently home in the data-visualizer-app's new "shared" package. This may change as we evolve the structure of the repositories.
Changes included in this PR:
sharedthat can contain common modules and componentsshared-- note that the ItemSelector component will be used by d2-ui PeriodSelector
ItemSelectorbased on the react-beautiful-dnd packagecolorsmodule to sharedFixes [DHIS2-5480]