Append correct paths for org units #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting parentGraphMap from visualization
joakimia
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
Tested the branch,
Root and Sub-org units have correct path appended:
"dimension": "ou",
"items": [
{
"id": "DiszpKrYNg8",
"name": "Ngelehun CHC",
"path": "/ImspTQPwCqd/O6uvpzGd5pu/YuQRtpLP10I/DiszpKrYNg8"
},
{
"id": "g8upMTyEZGZ",
"name": "Njandama MCHP",
"path": "/ImspTQPwCqd/O6uvpzGd5pu/YuQRtpLP10I/g8upMTyEZGZ"
}
]
}
|
🎉 This PR is included in version 33.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 32.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 9, 2020
This was referenced Jun 17, 2020
|
🎉 This PR is included in version 33.1.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to DHIS2-5987.
This PR covers some edge cases for "Open as map" feature and contains:
oudimension items (with/prefix) and supplying them to current analytical object in user data storeOrgUnitDimensiondialog.P.s. I had to reimplement
removeLastPathSegmentfunction which was earlier imported from@dhis2/d2-ui-org-unit-dialogcomponent, since importing causes circular dependency error (presumably coming from d2).