fix: use app runtime's datastore service v39 #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2238--dhis2-data-visualizer.netlify.app |
turban
approved these changes
Feb 28, 2023
Passing run #2450 ↗︎
Details:
Review all test suite changes for PR #2238 ↗︎ |
|||||||||||||||
|
🎉 This PR is included in version 39.2.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2235.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-14841
Key features
d2based user data store with the new oneDescription
Maps app swapped the old
d2implementation with the new datastore service fromapp-runtime.This means that the
View as Map/chartfunctionality is not working anymore between Maps and DV until this PR is merged.The new service use a different path for the data store keys.