Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use specific app class instead of generic 'app' to prevent side effects #248

Merged
merged 2 commits into from
Apr 10, 2019

Conversation

jenniferarnesen
Copy link
Collaborator

Fixes issue where the css for the apps in the headerbar app menu was messed up (had extremely big height and wrong bg color)

@janhenrikoverland janhenrikoverland merged commit ac6dad7 into master Apr 10, 2019
@janhenrikoverland janhenrikoverland deleted the chore/use-specific-css-name branch April 10, 2019 11:56
jenniferarnesen added a commit that referenced this pull request Apr 10, 2019
…e effects (#248)

* use specific app class instead of generic 'app' to prevent side effects

* remove withStyles
jenniferarnesen added a commit that referenced this pull request Apr 10, 2019
…e effects (#248)

* use specific app class instead of generic 'app' to prevent side effects

* remove withStyles
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 33.1.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants