task: single value chart type #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For SINGLE_VALUE dx must be moved in Series and all the rest in filters
When multiple items are selected for dx, only the first one is used for rendering the SINGLE_VALUE. A warning icon is shown and the label text shows that 1 item out of n is used. The tooltip only lists the one item that is used.
Also pass the output format to d2ca based on the visualization type
This is needed in the data dimension modal when single value visualization type is used. In that case only the first item is used and the others should be marked as inactive.
For Single Value visualization type show a message in the ItemSelector when more than 1 item are selected (but only the first is active)
The active flag is passed within the item's list instead of passing a callback in a dedicated prop to DataDimension component
Besides the "n of 1" string in the chip with the warning icon, the tooltip will read "Only 'item name' in use".
|
Chip color issue in item selector: When open the facility type item selector, and choose more than one facility type, the chip colors for the non-top items are faded green, but they should be the normal chip green for selected items. It may be getting this style from the rules for the data element.
|
Only the 1st item is saved when multiple items are selected in the UI
This was causing filtering of empty rows to not work when selecting the wrong "After first" option
janhenrikoverland
approved these changes
Aug 8, 2019
|
🎉 This PR is included in version 33.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 8, 2020
This was referenced Jun 17, 2020
|
🎉 This PR is included in version 33.1.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds the new visualization type in the type selector and implements the logic for the active/inactive items and the message in the info box in DataDimension shared component.
On a side note, I spoke with @cooper-joe about the possibility of changing the text in the info box to make it clear that is possible to reorder the items even if they look inactive, and that reordering affects the value rendered in the single value visualization.