fix: backport latest single value fixes in master #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Layout validation is run when the update button is clicked. This should avoid to load the plugin when there is an invalid layout which will likely cause an error due to missing expected data/config. Also, in the reducers we cannot always assume the layout has all the required dimensions/items, ie. when starting a viz from scratch and switch viz type or click the update button before selecting some required dimension item.
* fix: single value without dx items * fix: pass array instead of object * fix: fix prettier * fix: code style * @dhis2/analytics@2.4.0
janhenrikoverland
changed the title
This was referenced Jun 8, 2020
This was referenced Jun 17, 2020
|
🎉 This PR is included in version 33.1.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the latest work on single value charts.